Remove time inefficient loop in not_blocked_items #22862
Merged
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
reviewed
Nov 18, 2024
willdurand
requested changes
Nov 18, 2024
|
Ok @willdurand let's do it your way. I have things to say about your feedback but PR comments is not the place, especially when the goal here is to "unbreak prod on the short term" |
Remove test Revert reuse of reusable function
KevinMind
added a commit
that referenced
this pull request
Nov 18, 2024
Remove test Revert reuse of reusable function
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: mozilla/addons#15170
Description
Removes time inefficient loop in get_not_blocked_items by filtering from a once created set instead of an inlined list
Context
This patch adds a slow test 20 seconds that can be isolated from the rest of our tests in a follow up PR
Testing
CI passes, this PR will be verified on staging as well.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.